Mcsh5 offsets and proper scaling in uV for return_scaled #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yger
added
enhancement
for more information, see https://pre-commit.ci
h-mayorquin
approved these changes
Jun 6, 2024
| @@ -121,7 +124,8 @@ def openMCSH5File(filename, stream_id): | |||
| Tick = info["Tick"][0] / 1e6 | |||
| exponent = info["Exponent"][0] | |||
| convFact = info["ConversionFactor"][0] | |||
| gain = convFact.astype(float) * (10.0**exponent) | |||
| gain_uV = 1e6 * (convFact.astype(float) * (10.0**exponent)) | |||
| offset_uV = 1e6 * (info["ADZero"].astype(float) * (10.0**exponent)) | |||
There was a problem hiding this comment.
Given this from the specification:
Shouldn't the offset be negative?
There was a problem hiding this comment.
Indeed, you are right, this should be negative....
There was a problem hiding this comment.
In our implementation the offset is after the gain.
So the offset should be divided by gain I think. Can you check ?
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Does the dtype is always a uint ? why is there this offset ? |
alejoe91
reviewed
Jul 3, 2024
Co-authored-by: Alessio Buccino <[email protected]>
samuelgarcia
reviewed
Jul 5, 2024
samuelgarcia
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the offsets from the mcs5h header in order to have a recording with offset_to_UV and gain_to_UV. In addition, the gain was entered in V, and thus the scaling was not really making sense. As far as I understand, we want to have return_scaled returning values in uV, am I right? If yes, this is doing the job here, given the documentation that can be found online
https://www.multichannelsystems.com/sites/multichannelsystems.com/files/documents/manuals/HDF5%20MCS%20Raw%20Data%20Definition.pdf