Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KS4 parameters #2810

Merged
merged 2 commits into from
May 10, 2024
Merged

Update KS4 parameters #2810

merged 2 commits into from
May 10, 2024

Conversation

alejoe91
Copy link
Member

@alejoe91 alejoe91 commented May 6, 2024

Fixes #2806

  • Add max_channel_distance and x_centers parameters (default None)
  • Set duplicate_spike_bins to new dafault of 7

@alejoe91 alejoe91 added the sorters Related to sorters module label May 6, 2024
@@ -81,6 +84,7 @@ class Kilosort4Sorter(BaseSorter):
"ccg_threshold": "Fraction of refractory period violations that are allowed in the CCG compared to baseline; used to perform splits and merges. Default value: 0.25.",
"cluster_downsampling": "Inverse fraction of nodes used as landmarks during clustering (can be 1, but that slows down the optimization). Default value: 20.",
"cluster_pcs": "Maximum number of spatiotemporal PC features used for clustering. Default value: 64.",
"x_centers": "Number of x-positions to use when determining center points for template groupings. If None, this will be determined automatically by finding peaks in channel density. For 2D array type probes, we recommend specifying this so that centers are placed every few hundred microns.",
"duplicate_spike_bins": "Number of bins for which subsequent spikes from the same cluster are assumed to be artifacts. A value of 0 disables this step. Default value: 15.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicate_spike_bins default needs to be switched to 7 as well :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zach you must have at least 3 pairs of eyes!!! Fixed

Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We should probably remember to do it in bug fixes as well.

@alejoe91 alejoe91 merged commit 37ba54d into SpikeInterface:main May 10, 2024
11 checks passed
alejoe91 added a commit to alejoe91/spikeinterface that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorters Related to sorters module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments on Kilosort 4 parameters
2 participants