-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing curation : get_potential_auto_merge() #2753
Enhancing curation : get_potential_auto_merge() #2753
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@alejoe91 this is OK for me. Pierre will need this for circus. |
I pulled the changed and ran the Lussac unit tests (which check that units that should be merged are indeed merged) I get this error:
|
Aie. The bug seems to be more in the sorting_analyzer object. Or I should catch the fact that maybe the get_data() for the "templates" extension is not properly able to return Templates when more than one probes are selected. What do you think @samuelgarcia ? Otherwise, if more than one probe is detected, then we get Templates with the 'average' method, as it used to be done before. The following function will work properly since it can handled Templates or numpy arrays as input |
…auto_merge() when analyzer has several probes.
@DradeAW I made a fix for multiple probe. |
for more information, see https://pre-commit.ci
All tests have passed on my end! :) |
This PR improve
get_potential_auto_merge()
with:@DradeAW : can you check this, if you use this in Lussac. Normally the behavior is the same as before.