-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML __repr__
for Sorting objects
#2747
HTML __repr__
for Sorting objects
#2747
Conversation
I think this looks super cool, but as someone who does not know HTML at all I wonder what the developer burden would be for this? I definitely couldn't help with this if we add html in at this point, but if everyone else knows HTML then I think the usefulness factor would outweigh the development concerns. |
I think this is a good consideration. Two points to add to the estimate of developer burden:
|
This is cool, a quick suggestion for maintainability would be to include functions that generate html representations in a separate module. This Maybe the pattern could be something like:
( The three benfits I see from this are:
|
I would like to wait till we do the SortingAnalyser representation to generalize and abstract. Knowing my personal tendencies I am more prone to generalizing too early and overthinking rather than uneceesarily duplicating code. Once we have three examples (sorting, recording and sortinganalyser) I would be glad to work with you on putting this on a module on its own, what do you think? |
Hey @h-mayorquin sorry for late reply, this makes sense! Let me know when the time is right, would be happy to help. |
I was working on html representation last week https://ipython.readthedocs.io/en/stable/config/integrating.html and I realize there is low hanging fruit for using them in our objects. This is an example for the sorting objects. If this works and you guys agree we can create a similar one for the recording objects. Also, it would be good to include general annotations.
Any suggestions are welcome
This is how it looks:
Screencast.from.2024-04-22.12-35-30.webm