Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port bug fix PRs from Main over to 0.100-bug-fixes #2720

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Apr 15, 2024

PRs #2701 , #2690, #2716

Were there any other that we needed to port over?

@zm711 zm711 added the bug Something isn't working label Apr 15, 2024
@alejoe91
Copy link
Member

I think it's good! Maybe let's make a new 0.100.6 release? @zm711 do you mind if I push here release notes and version bump?

@zm711
Copy link
Collaborator Author

zm711 commented Apr 16, 2024

Yeah sure. Works for me!

@zm711
Copy link
Collaborator Author

zm711 commented Apr 17, 2024

Don't merge until we decide on solution for #2710 (side left might be wrong strategy).

@zm711
Copy link
Collaborator Author

zm711 commented Apr 17, 2024

Forgot to update has_exceeding_spikes. This has now been patched here!

@zm711
Copy link
Collaborator Author

zm711 commented Apr 18, 2024

Confirmed from two end-users that the patch for remove_excess_spikes works!

@luiztauffer
Copy link
Collaborator

@zm711 can we have this merged? It would be helpful for me

@zm711
Copy link
Collaborator Author

zm711 commented Apr 25, 2024

Hey @luiztauffer! I think @alejoe91 was deciding whether to add release notes to this PR. It's ready on my side (although there is another issue with KS4 that we might want to package first #2742).

@alejoe91
Copy link
Member

Let's merge this now. We can make release notes and the ks405 fix later

@alejoe91 alejoe91 merged commit 449e219 into SpikeInterface:0.100-bug-fixes Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants