Matched filtering to enhance peak detection #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to matched_filtering
for more information, see https://pre-commit.ci
…matched_filtering
…matched_filtering
… into matched_filtering
…matched_filtering
…matched_filtering
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
samuelgarcia
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I've added at new node to detect peaks via matched filtering. The node accepts a prototype waveform, and will create spatio-temporal templates to convolve the traces with during peak detection, in order to increase the SNR (exactly as done in KS). This is working quite well, boosting quite a lot the detection, and thus the clustering. In a forseable future, SC2 will use it by default, more tests are needed.