-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docstring
section to development docs
#2138
Conversation
also fix some typos
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for more information, see https://pre-commit.ci
While you're checking this out @h-mayorquin. I know you added the datalad instructions but I for one can't get datalad working on Mac ( m-series). I think there is a mismatch between datalad, git-annex, and brew. I'll update those instructions if I can figure it out, but just wanted that on your radar in case you know any magic tips for getting it to work. |
@zm711 I was kind of proud that I got datalad working for all the three OSs in the CI at some point in time. This was accomplished using those instructions. Because of the Sam moratorium on testing we ended up not using that but ... flawed human as I am, I wanted to keep those instructions somewhere and they ended up there. In retrospective, this is wrong. We are doing duplication by keeping those instructions there and, even worse, making promises that we don't know if we can keep ("the method works"). We should just point out to the documentation in datalad and be done with it. Plus, now that we have good generators we will be getting rid of Datalad for core testing (which is great!) so this is even less necessary as we will only be needing if for extractor testing. |
First off I always super appreciate all your hard work getting the ci working @h-mayorquin!
I agree. I think switching the examples to the generators (in the modules gallery) would be super beneficial. Because right now we allow people to download the scripts, but the scripts will fail if the user doesn't have datalad.
I'll change the datalad section right now just so that we don't "over-promise". (I was able to get datalad with windows, but I had to specify my git-annex version in the datalad installer and jump through a couple hoops, so yeah I think the packages are just changing at different rates, which makes it hard to have the instructions just work). Also just as an fyi (since you worked so hard on the ci). I recently tried to run the whole test-suite on windows (I ended about 7/8 of the way through) and ended up with something like 50-60 test failures. Mostly due to |
Thanks for testing this on windows. In the last meeting we discussed testing. I am hoping that by the end of this week and next week I will be working in some outstanding* maintenance issues which will include testing. (I just realized that this is synonym with great which I find strange) |
for more information, see https://pre-commit.ci
A companion documentation section to go with @alejoe91 #2134. This way future developers will be adequately warned about what is expected in the docstrings.
Read through the docstring section and let me know if you want me to include more info.
Other minor changes
*I restylized black to Black since that is their official name whereas black is the package (similar to this repo :) )
* added a note about fmt skip vs fmt off for black
* couple typo fixes
One question is near the bottom the section originally said edit the travis.yml, but I assumed it was suppose to be edit the pyproject to add the dependencies to the test section, but if I'm wrong correct that section.