Some improvement in Study and related widgets #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
reviewed
Oct 25, 2023
Co-authored-by: Zach McKenzie <[email protected]>
alejoe91
added
widgets
|
@alejoe91 ready to merge on my side. |
for more information, see https://pre-commit.ci
zm711
reviewed
Oct 25, 2023
| @@ -140,16 +134,18 @@ class StudyPerformances(BaseWidget): | |||
| study: GroundTruthStudy | |||
| A study object. | |||
| mode: str | |||
| Which mode in "swarm" | |||
| Which mode in "ordered", "snr", "swarm" | |||
There was a problem hiding this comment.
I don't know what 'swarm' is... Is this common knowledge or would it be beneficial to define this? How would a user know when to use 'ordered' vs 'snr' vs 'swarm'....
There was a problem hiding this comment.
@zm711 I think it's quite common, but we can ref the seaborn page: https://seaborn.pydata.org/generated/seaborn.swarmplot.html
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
zm711
reviewed
Oct 26, 2023
Comment on lines
+137
to
+141
| Which plot mode to use: | ||
|
|
||
| * "ordered": plot performance metrics vs unit indices ordered by decreasing accuracy (default) | ||
| * "snr": plot performance metrics vs snr | ||
| * "swarm": plot performance metrics as a swarm plot (see seaborn.swarmplot for details) |
There was a problem hiding this comment.
Thanks That's super helpful @alejoe91
alejoe91
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
@samuelgarcia we'll need more checks at some point to know if different study steps have run. Also removed some debug plots in the merge.py that were active by default!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.