Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assert messages (preprocessing & core) #2078

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Oct 5, 2023

My main goal for the next couple PRs will be to

  1. fix typos in asserts/exceptions/etc
  2. add assert/exception/etc messages when they are lacking to make sure users can provide that info in GH issues

I started fixing a docstring/typing for one file, but I decided I wanted to keep this PR within a scope of just improving messaging around errors. I also want to do this in a couple PRs so I can get some feedback before I do all files.

@samuelgarcia
Copy link
Member

Zach, you are amazingly heroic !
If you come to Lyon to will receive a bottle of cote du Rhone for this.
If Alessio do the same with an Italian wine, you will be able compare and rank the two flavor.
The result should make Alessio grumpy.

@alejoe91 alejoe91 added the enhancement New feature or request label Oct 6, 2023
@alejoe91 alejoe91 merged commit 0bf1b89 into SpikeInterface:main Oct 6, 2023
8 checks passed
@zm711 zm711 deleted the clean-asserts branch October 6, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants