Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix firing range when bin size is to small #2054

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Fix firing range when bin size is to small #2054

merged 2 commits into from
Sep 29, 2023

Conversation

alejoe91
Copy link
Member

Fixes #2052

@alejoe91 alejoe91 added bug Something isn't working qualitymetrics Related to qualitymetrics module labels Sep 29, 2023
h-mayorquin
h-mayorquin approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks Alessio.

@h-mayorquin h-mayorquin merged commit c8be1a0 into SpikeInterface:main Sep 29, 2023
8 checks passed
@alejoe91 alejoe91 deleted the fix-firing-range branch October 17, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
bug Something isn't working qualitymetrics Related to qualitymetrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in compute_firing_ranges when duration of recording is smaller than default time bin_s
2 participants
@alejoe91 @h-mayorquin