Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellExplorer: fix tests and deprecation #2048

Merged
merged 2 commits into from
Sep 28, 2023
Merged

CellExplorer: fix tests and deprecation #2048

merged 2 commits into from
Sep 28, 2023

Conversation

alejoe91
Copy link
Member

We had a deprecation period in the CellExplorerSorting which has expired.

This PR updates the tests and raises an exception ins tead of a warning.

@alejoe91 alejoe91 added the extractors Related to extractors module label Sep 28, 2023
@alejoe91 alejoe91 mentioned this pull request Sep 28, 2023
Merged
h-mayorquin
h-mayorquin approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Can you drop it from the init as well,

@alejoe91
Copy link
Member Author

Thanks. Can you drop it from the init as well,

done

@h-mayorquin h-mayorquin merged commit 986fe6f into SpikeInterface:main Sep 28, 2023
8 checks passed
@alejoe91 alejoe91 deleted the fix-cellexplorer-tests branch October 17, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
extractors Related to extractors module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejoe91 @h-mayorquin