Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nested tutorials #2036

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix for nested tutorials #2036

merged 3 commits into from
Sep 22, 2023

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Sep 22, 2023

This is a PR testing what is causing #1964. Since I can't recreate locally I will just test some things in the CI.

@zm711
Copy link
Collaborator Author

zm711 commented Sep 22, 2023

But if anyone else wants to try a test feel free to commit directly into this.

@zm711
Copy link
Collaborator Author

zm711 commented Sep 22, 2023

So moving core to the bottom of the ExplicitOrder switched it to be the nested tutorial. So there is something about the last entry in that order that is messing this up.

@zm711 zm711 added documentation Improvements or additions to documentation continuous integration Related to CI labels Sep 22, 2023
@zm711
Copy link
Collaborator Author

zm711 commented Sep 22, 2023

Still nested if I clean up the extra slashes.

@zm711
Copy link
Collaborator Author

zm711 commented Sep 22, 2023

So I started reading the sphinx_gallery issue tracker and seems like the fix is what I implemented. And looks fixed to me in the rtd build.

image
image

@zm711 zm711 changed the title Do Not Merge Testing for #1964 Nested Tutorials Fix for nested tutorials Sep 22, 2023
@zm711
Copy link
Collaborator Author

zm711 commented Sep 22, 2023

Fixes #1964

@zm711 zm711 marked this pull request as ready for review September 22, 2023 15:13
@zm711 zm711 removed the continuous integration Related to CI label Sep 22, 2023
@alejoe91
Copy link
Member

alejoe91 commented Sep 22, 2023

Thank you so much Zach!

@alejoe91 alejoe91 merged commit ff1b8cd into SpikeInterface:main Sep 22, 2023
8 checks passed
@zm711 zm711 deleted the rtd-nested branch September 22, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants