Extend and refactor waveform metrics #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
reviewed
Sep 29, 2023
|
Thanks @zm711 Aplied the suggested changes. @samuelgarcia @h-mayorquin good to merge |
samuelgarcia
reviewed
Oct 6, 2023
| @@ -2016,6 +2032,9 @@ def set_params(self, **params): | |||
| params = self._set_params(**params) | |||
| self._params = params | |||
|
|
|||
| if self.waveform_extractor.is_read_only(): | |||
There was a problem hiding this comment.
Maybe we should run error instead no ?
set_params on read only should be allowed.
There was a problem hiding this comment.
It is allowed, but only in mem in this case
There was a problem hiding this comment.
henestly set_params to a read only should be not aalowed.
What is the use here ?
There was a problem hiding this comment.
It skips saving to disk!
samuelgarcia
reviewed
Oct 6, 2023
| sparsity: Optional[ChannelSparsity] = None, | ||
| include_multi_channel_metrics: bool = False, | ||
| metrics_kwargs: dict = None, | ||
| debug_plots: bool = False, |
There was a problem hiding this comment.
I am OK to have debug_plot inside the code at the tricky places but I would avoid this in the signauture
There was a problem hiding this comment.
Ok, I can remove it and set it as a flag on top of the file
samuelgarcia
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented additional metrics:
Single-channel
Multi-channel
Closes #1185