Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax check_borders in InjectTemplatesRecording #1988

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Relax check_borders in InjectTemplatesRecording #1988

merged 1 commit into from
Sep 13, 2023

Conversation

alejoe91
Copy link
Member

The check_borders should be eventually moved outside (and it's making a bunch of thests failing at the moment)

@alejoe91 alejoe91 added the core Changes to core module label Sep 13, 2023
h-mayorquin
h-mayorquin approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this.

@alejoe91 alejoe91 merged commit c94c8ae into SpikeInterface:main Sep 13, 2023
8 checks passed
@alejoe91 alejoe91 deleted the remove-hybtid-templates-check branch October 17, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
core Changes to core module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejoe91 @h-mayorquin