-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement syncrhrony metrics #1951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple typo suggestions, and a wording clarification.
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
@samuelgarcia thanks for the tip! The implementation with |
Co-authored-by: Garcia Samuel <[email protected]>
@samuelgarcia is this ok to merge? |
@musall @Moritz-Alexander-Kern : would you have time to look to this to valide that this new code correcpond to the method ? |
I can point to a gist that shows equivalence with the |
The code looks good to me. |
I agree, thanks for the implementation. |
Replaces #1205
@musall @Moritz-Alexander-Kern
Implements synchrony metrics low-level, without depending on
elephant
.Default values for synchrony sizes are 2, 4, and 8. Sizes <= 1 throuw an error, as every spike will have a complexity of at least 1.
TODO