Skip to content

Commit

Permalink
Merge pull request #3339 from chrishalcrow/only-allow-above-ks-4-16
Browse files Browse the repository at this point in the history
Updates to kilosort 4: version >= 4.0.16, `bad_channels`, `clear_cache`, `use_binary_file`
  • Loading branch information
alejoe91 authored Sep 6, 2024
2 parents 24f0541 + fd61bb6 commit d5f1481
Show file tree
Hide file tree
Showing 12 changed files with 405 additions and 316 deletions.
2 changes: 1 addition & 1 deletion .github/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ fi

pytest -m "$MARKER" -vv -ra --durations=0 --durations-min=0.001 | tee report.txt; test ${PIPESTATUS[0]} -eq 0 || exit 1
echo "# Timing profile of ${MARKER}" >> $GITHUB_STEP_SUMMARY
python $GITHUB_WORKSPACE/.github/build_job_summary.py report.txt >> $GITHUB_STEP_SUMMARY
python $GITHUB_WORKSPACE/.github/scripts/build_job_summary.py report.txt >> $GITHUB_STEP_SUMMARY
rm report.txt
File renamed without changes.
9 changes: 2 additions & 7 deletions .github/scripts/check_kilosort4_releases.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@ def get_pypi_versions(package_name):
response.raise_for_status()
data = response.json()
versions = list(sorted(data["releases"].keys()))

assert parse(spikeinterface.__version__) < parse("0.101.1"), (
"Kilosort 4.0.5-12 are supported in SpikeInterface < 0.101.1."
"At version 0.101.1, this should be updated to support newer"
"kilosort verrsions."
)
versions = [ver for ver in versions if parse("4.0.12") >= parse(ver) >= parse("4.0.5")]
# Filter out versions that are less than 4.0.16
versions = [ver for ver in versions if parse(ver) >= parse("4.0.16")]
return versions


Expand Down
File renamed without changes.
File renamed without changes.
Loading

0 comments on commit d5f1481

Please sign in to comment.