Skip to content

Commit

Permalink
parentheses
Browse files Browse the repository at this point in the history
  • Loading branch information
h-mayorquin committed Apr 14, 2023
1 parent 82f6865 commit d3eb3ca
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .github/actions/build-test-environment/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
sudo apt install git
git config --global user.email "[email protected]"
git config --global user.name "CI Almighty"
python -m venv ${{ github.workspace }}/test_env
python -m venv ${{ github.workspace }}/test_env # Environment used in the caching step
python -m pip install -U pip # Official recommended way
source ${{ github.workspace }}/test_env/bin/activate
pip install tabulate # This produces summaries at the end
Expand Down
2 changes: 1 addition & 1 deletion .github/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
MARKER=$1

source $GITHUB_WORKSPACE/test_env/bin/activate
pytest -m $MARKER -vv -ra --durations=0 --durations-min=0.001 | tee report.txt; test ${PIPESTATUS[0]} -eq 0 || exit 1
pytest -m "$MARKER" -vv -ra --durations=0 --durations-min=0.001 | tee report.txt; test ${PIPESTATUS[0]} -eq 0 || exit 1
echo "# Timing profile of ${MARKER}" >> $GITHUB_STEP_SUMMARY
python $GITHUB_WORKSPACE/.github/build_job_summary.py report.txt >> $GITHUB_STEP_SUMMARY
rm report.txt
23 changes: 7 additions & 16 deletions .github/workflows/caches_cron_job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,14 @@ jobs:
- uses: actions/cache@v3
id: cache-venv
with:
path: ~/test_env
path: ${{ github.workspace }}/test_env
key: ${{ runner.os }}-venv-${{ steps.dependencies.outputs.hash }}-${{ steps.date.outputs.date }}
- name: Cache found?
run: echo "Cache-hit == ${{steps.cache-venv.outputs.cache-hit == 'true'}}"
- name: Create the virtual environment to be cached
if: steps.cache-venv.outputs.cache-hit != 'true'
run: |
git config --global user.email "[email protected]"
git config --global user.name "CI Almighty"
python -m venv ~/test_env # Environment used in the caching step
source ~/test_env/bin/activate
python -m pip install -U pip # Official recommended way
# herdingspikes need numpy to installed first (!)
pip install numpy==1.22
pip install -e .[test,extractors,full]
create-data-cache-if-missing:
uses: ./.github/actions/build-test-environment
create-gin-data-cache-if-missing:
name: Caching data env
runs-on: "ubuntu-latest"
steps:
Expand All @@ -61,7 +52,7 @@ jobs:
- uses: actions/cache@v3
id: cache-datasets
with:
path: ~/spikeinterface_datasets
path: ${{ github.workspace }}/spikeinterface_datasets
key: ${{ runner.os }}-datasets-${{ steps.repo_hash.outputs.dataset_hash }}
- name: Cache found?
run: echo "Cache-hit == ${{steps.cache-datasets.outputs.cache-hit == 'true'}}"
Expand All @@ -82,11 +73,11 @@ jobs:
- name: Move the downloaded data to the right directory
if: steps.cache-datasets.outputs.cache-hit != 'true'
run: |
mkdir --parents --verbose ~/spikeinterface_datasets/ephy_testing_data/
mv --force ./ephy_testing_data ~/spikeinterface_datasets/
mkdir --parents --verbose ${{ github.workspace }}/spikeinterface_datasets/ephy_testing_data/
mv --force ./ephy_testing_data ${{ github.workspace }}/spikeinterface_datasets/
- name: Show size of the cache to assert data is downloaded
run: |
cd ~
cd ${{ github.workspace }}
pwd
du -hs spikeinterface_datasets
cd spikeinterface_datasets
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/full-test-with-codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
# the key depends on the last comit repo https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git
HASH_EPHY_DATASET: git ls-remote https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git HEAD | cut -f1
with:
path: ~/spikeinterface_datasets
path: ${{ github.workspace }}/spikeinterface_datasets
key: ${{ runner.os }}-datasets-${{ steps.vars.outputs.HASH_EPHY_DATASET }}
restore-keys: |
${{ runner.os }}-datasets
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/full-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
# the key depends on the last comit repo https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git
HASH_EPHY_DATASET: git ls-remote https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git HEAD | cut -f1
with:
path: ~/spikeinterface_datasets
path: ${{ github.workspace }}/spikeinterface_datasets
key: ${{ runner.os }}-datasets-${{ steps.vars.outputs.HASH_EPHY_DATASET }}
restore-keys: |
${{ runner.os }}-datasets
Expand Down

0 comments on commit d3eb3ca

Please sign in to comment.