Merge pull request #2786 from h-mayorquin/add_select_channels

Add `select_channels` method to base recording

src/spikeinterface/core/baserecording.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 import warnings
 from pathlib import Path
-from warnings import warn
 
 import numpy as np
 from probeinterface import Probe, ProbeGroup, read_probeinterface, select_axes, write_probeinterface
@@ -12,10 +11,8 @@
     convert_bytes_to_str,
     convert_seconds_to_str,
 )
-from .recording_tools import (
-    write_binary_recording,
-    write_memory_recording,
-)
+from .recording_tools import write_binary_recording
+
 
 from .job_tools import split_job_kwargs
 
@@ -426,7 +423,7 @@ def set_times(self, times, segment_index=None, with_warning=True):
         rs.time_vector = times.astype("float64", copy=False)
 
         if with_warning:
-            warn(
+            warnings.warn(
                 "Setting times with Recording.set_times() is not recommended because "
                 "times are not always propagated across preprocessing"
                 "Use this carefully!"
@@ -550,10 +547,27 @@ def _extra_metadata_to_folder(self, folder):
             if time_vector is not None:
                 np.save(folder / f"times_cached_seg{segment_index}.npy", time_vector)
 
-    def rename_channels(self, new_channel_ids: list | np.array | tuple):
+    def select_channels(self, channel_ids: list | np.array | tuple) -> "BaseRecording":
+        """
+        Returns a new recording object with a subset of channels.
+
+        Note that this method does not modify the current recording and instead returns a new recording object.
+
+        Parameters
+        ----------
+        channel_ids : list or np.array or tuple
+            The channel ids to select.
+        """
+        from .channelslice import ChannelSliceRecording
+
+        return ChannelSliceRecording(self, channel_ids)
+
+    def rename_channels(self, new_channel_ids: list | np.array | tuple) -> "BaseRecording":
         """
         Returns a new recording object with renamed channel ids.
 
+        Note that this method does not modify the current recording and instead returns a new recording object.
+
         Parameters
         ----------
         new_channel_ids : list or np.array or tuple
@@ -570,6 +584,10 @@ def rename_channels(self, new_channel_ids: list | np.array | tuple):
     def _channel_slice(self, channel_ids, renamed_channel_ids=None):
         from .channelslice import ChannelSliceRecording
 
+        warnings.warn(
+            "This method will be removed in version 0.103, use `select_channels` or `rename_channels` instead.",
+            DeprecationWarning,
+        )
         sub_recording = ChannelSliceRecording(self, channel_ids, renamed_channel_ids=renamed_channel_ids)
         return sub_recording
 

src/spikeinterface/core/channelslice.py

@@ -11,7 +11,7 @@ class ChannelSliceRecording(BaseRecording):
     """
     Class to slice a Recording object based on channel_ids.
 
-    Do not use this class directly but use `recording.channel_slice(...)`
+    Not intending to be used directly, use methods of `BaseRecording` such as `recording.select_channels`.
 
     """
 

src/spikeinterface/core/tests/test_baserecording.py

@@ -358,5 +358,13 @@ def test_rename_channels():
     assert np.array_equal(renamed_channel_ids, ["a", "b", "c"])
 
 
+def test_select_channels():
+    recording = generate_recording(durations=[1.0], num_channels=3)
+    renamed_recording = recording.rename_channels(new_channel_ids=["a", "b", "c"])
+    selected_recording = renamed_recording.select_channels(channel_ids=["a", "c"])
+    selected_channel_ids = selected_recording.get_channel_ids()
+    assert np.array_equal(selected_channel_ids, ["a", "c"])
+
+
 if __name__ == "__main__":
     test_BaseRecording()