Skip to content

Commit

Permalink
Merge pull request #3037 from zm711/fix-base-sorter
Browse files Browse the repository at this point in the history
Make sure we check `is_filtered()` rather than bound method during run basesorter
  • Loading branch information
alejoe91 authored Jun 18, 2024
2 parents c96ce87 + 330c38c commit a3527ea
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/spikeinterface/sorters/basesorter.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def set_params_to_folder(cls, recording, output_folder, new_params, verbose):
# custom check params
params = cls._check_params(recording, output_folder, params)
# common check : filter warning
if recording.is_filtered and cls._check_apply_filter_in_params(params) and verbose:
if recording.is_filtered() and cls._check_apply_filter_in_params(params) and verbose:
print(f"Warning! The recording is already filtered, but {cls.sorter_name} filter is enabled")

# dump parameters inside the folder with json
Expand Down
1 change: 0 additions & 1 deletion src/spikeinterface/sorters/external/mountainsort5.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ def _setup_recording(cls, recording, sorter_output_folder, params, verbose):
@classmethod
def _run_from_folder(cls, sorter_output_folder, params, verbose):
import mountainsort5 as ms5
from mountainsort5.util import create_cached_recording

recording = cls.load_recording_from_folder(sorter_output_folder.parent, with_warnings=False)
if recording is None:
Expand Down

0 comments on commit a3527ea

Please sign in to comment.