Merge pull request #2292 from alejoe91/shell-script

Close ShellScript process at deletion
SpikeInterface · Dec 6, 2023 · 8e32955 · 8e32955
2 parents 170eefb + 452a722
commit 8e32955
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/spikeinterface/sorters/basesorter.py b/src/spikeinterface/sorters/basesorter.py
@@ -361,7 +361,6 @@ def check_compiled(cls):
         """
         shell_script = ShellScript(shell_cmd)
         shell_script.start()
-        shell_script.wait()
         retcode = shell_script.wait()
         if retcode != 0:
             return False

diff --git a/src/spikeinterface/sorters/utils/shellscript.py b/src/spikeinterface/sorters/utils/shellscript.py
@@ -110,6 +110,8 @@ def cleanup(self) -> None:
             return
         for dirpath in self._dirs_to_remove:
             _rmdir_with_retries(str(dirpath), num_retries=5)
+        if self._process is not None:
+            self._process.kill()
 
     def stop(self) -> None:
         if not self.isRunning():