-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new wiring for CambridgeNeurotech 64-Ch adaptor #307
base: main
Are you sure you want to change the base?
Conversation
Added a new wiring for CambridgeNeurotech 64-Ch adaptor ("ADPT A64-Om32x2"; Samtec to 2x Omnetics) to RHD2164. Verified by own recordings.
for more information, see https://pre-commit.ci
@@ -25,13 +25,20 @@ | |||
24, 23, 25, 22, 26, 21, 27, 20, 28, 19, 29, 18, 30, 17, 31, 16, 0, | |||
15, 1, 14, 2, 13, 3, 12, 4, 11, 5, 10, 6, 9, 7, 8], | |||
|
|||
# nicely given by Aaron Wrong | |||
# nicely given by Aaron Wong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was Wrong ehehehe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XD
Hi @aaronbwong Thank you so much! Can you paste here relevant screenshots with the probe/headstage mapping so we can cross-validate? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 89.38% 89.38%
=======================================
Files 10 10
Lines 1885 1885
=======================================
Hits 1685 1685
Misses 200 200 ☔ View full report in Codecov by Sentry. |
This is a codes snippet I used to generate the mapping in probe interface: The source maps Note that this connection is with the PCB component side of the RHD2164 placed on the same side as the Samtec connector of the adaptor. I also have a map for the flipped connection, which I have not validated with data. Let me know if that'd be helpful or instead more confusing to also post the other way. |
Hi Aaron. Thanks for this. |
Yep. It is. This would be a nice extra verification. :) |
'ASSY-77>Adpt.A64-Om32_2x-sm-NN>RHD2164': [ | ||
62, 63, 60, 61, 59, 58, 57, 56, 55, 54, 53, 52, 51, 50, 49, 48, | ||
32, 33, 34, 35, 37, 36, 39, 41, 43, 45, 47, 38, 42, 44, 46, 40, | ||
22, 16, 18, 20, 24, 17, 19, 21, 23, 25, 26, 27, 29, 28, 31, 30, | ||
14, 15, 12, 13, 10, 11, 8, 9, 6, 7, 4, 5, 3, 2, 1, 0], | ||
|
||
# mapping from the CambridgeNeurotech ("CN") adaptor (https://www.cambridgeneurotech.com/assets/files/ADPT-A64-Om32x2-map.pdf), by Aaron Wong | ||
'ASSY-77>Adpt.A64-Om32x2-CN>RHD2164': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do cambridgeneurotech instead of CN.NN
from before messed with a lot of people. I think we should be explicit moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does sound prudent. I'm for putting cambridgeneurotech in it.
If you're going to add this PR instead of #304 (which is fine we can close the original since this has the full stuff and I don't have time to generate the image) could you add in the extra verification notes from our PR in. We re-confirmed our submission in addition to other submissions. So we want the comments to include all verifiers. |
Hi Samuel and Alessio,
Since kilosort4 is out, I recently came back to spikeinterface. Meanwhile I got a new adaptor from CambridgeNeurotech and thus tested the wiring via probeinterface. I hope you don't mind me directly adding it into wiring.py. (It is again one of two possible ways of connecting the headstage.) If you need I can provide some raw data for verification. Commit message:
Added a new wiring for CambridgeNeurotech 64-Ch adaptor ("ADPT A64-Om32x2"; Samtec to 2x Omnetics) to RHD2164. Verified by own recordings.
Also corrected my own name ;P