Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new wiring for CambridgeNeurotech 64-Ch adaptor #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aaronbwong
Copy link

Hi Samuel and Alessio,

Since kilosort4 is out, I recently came back to spikeinterface. Meanwhile I got a new adaptor from CambridgeNeurotech and thus tested the wiring via probeinterface. I hope you don't mind me directly adding it into wiring.py. (It is again one of two possible ways of connecting the headstage.) If you need I can provide some raw data for verification. Commit message:

Added a new wiring for CambridgeNeurotech 64-Ch adaptor ("ADPT A64-Om32x2"; Samtec to 2x Omnetics) to RHD2164. Verified by own recordings.

Also corrected my own name ;P

aaronbwong and others added 2 commits November 11, 2024 14:36
Added a new wiring for CambridgeNeurotech 64-Ch adaptor ("ADPT A64-Om32x2"; Samtec to 2x Omnetics) to RHD2164. Verified by own recordings.
@@ -25,13 +25,20 @@
24, 23, 25, 22, 26, 21, 27, 20, 28, 19, 29, 18, 30, 17, 31, 16, 0,
15, 1, 14, 2, 13, 3, 12, 4, 11, 5, 10, 6, 9, 7, 8],

# nicely given by Aaron Wrong
# nicely given by Aaron Wong
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was Wrong ehehehe

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD

@alejoe91
Copy link
Member

Hi @aaronbwong

Thank you so much! Can you paste here relevant screenshots with the probe/headstage mapping so we can cross-validate?

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (1fc2d35) to head (b35ca8f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files          10       10           
  Lines        1885     1885           
=======================================
  Hits         1685     1685           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronbwong
Copy link
Author

Hi @aaronbwong

Thank you so much! Can you paste here relevant screenshots with the probe/headstage mapping so we can cross-validate?

This is a codes snippet I used to generate the mapping in probe interface:
image
The results in probe interface:
channel map

The source maps
Probe layout:
ASSY-77-H5
Samtec to omnetics adaptor (note the channel numbering at the Samtec is exactly the same as the probe's):
image
RHD2164 channel map:
image

Note that this connection is with the PCB component side of the RHD2164 placed on the same side as the Samtec connector of the adaptor.

I also have a map for the flipped connection, which I have not validated with data. Let me know if that'd be helpful or instead more confusing to also post the other way.

@samuelgarcia
Copy link
Member

Hi Aaron. Thanks for this.
@zm711 : is it the one we did ?

@zm711
Copy link
Contributor

zm711 commented Nov 15, 2024

@zm711 : is it the one we did ?

Yep. It is. This would be a nice extra verification. :)

'ASSY-77>Adpt.A64-Om32_2x-sm-NN>RHD2164': [
62, 63, 60, 61, 59, 58, 57, 56, 55, 54, 53, 52, 51, 50, 49, 48,
32, 33, 34, 35, 37, 36, 39, 41, 43, 45, 47, 38, 42, 44, 46, 40,
22, 16, 18, 20, 24, 17, 19, 21, 23, 25, 26, 27, 29, 28, 31, 30,
14, 15, 12, 13, 10, 11, 8, 9, 6, 7, 4, 5, 3, 2, 1, 0],

# mapping from the CambridgeNeurotech ("CN") adaptor (https://www.cambridgeneurotech.com/assets/files/ADPT-A64-Om32x2-map.pdf), by Aaron Wong
'ASSY-77>Adpt.A64-Om32x2-CN>RHD2164': [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do cambridgeneurotech instead of CN.NN from before messed with a lot of people. I think we should be explicit moving forward.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does sound prudent. I'm for putting cambridgeneurotech in it.

@zm711
Copy link
Contributor

zm711 commented Nov 15, 2024

If you're going to add this PR instead of #304 (which is fine we can close the original since this has the full stuff and I don't have time to generate the image) could you add in the extra verification notes from our PR in. We re-confirmed our submission in addition to other submissions. So we want the comments to include all verifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants