-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docstrings-style compliant and add assert messaging #241
Conversation
The tests I broke were designed to prevent users from messing up. I'll take a look. |
…into docstrings
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 88.90% 88.92% +0.02%
==========================================
Files 10 10
Lines 1694 1698 +4
==========================================
+ Hits 1506 1510 +4
Misses 188 188 ☔ View full report in Codecov by Sentry. |
So one of the test failures was because I changed the type of error from The other set of failures were due to the fixture not specifying the Coverage drop is just because I made some asserts multiple lines and not all asserts are being tested. |
for more information, see https://pre-commit.ci
…into docstrings
for more information, see https://pre-commit.ci
…into docstrings
Okay I'm all done with everything -- I won't push anything unless I get feedback. As a reminder (to check super carefully): |
Thanks @zm711 I'll review between today and tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zm711
I requested a small change regarding the use of |
and list[]
for typing, which I believe needs from __future__ import annotations
.
Could you add that when needed?
Just to be safe I added future to all files (like Heberto has said, it's easy to miss that since we only test on 3.10), so since ProbeInterface is a pretty small code base I think it safer to just have from future everywhere and then we can delete it later. I also added .ds_store to the gitignore since I do some work on Macs and don't want to accidentally upload a bunch of folder organization files :) coverage failed which caused the test to fail. Could you try just re-running the test :) |
So I switched most of the docstrings over to the SI format (I'm sure I'm missed some though) and I tried to add assert messaging to help users.