Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify NP reading with probe part number #232

Merged
merged 12 commits into from
Nov 2, 2023
Merged

Unify NP reading with probe part number #232

merged 12 commits into from
Nov 2, 2023

Conversation

alejoe91
Copy link
Member

@alejoe91 alejoe91 commented Nov 2, 2023

  • Use probe_part_number in OE and imDatPrb_pn in SpikeGLX to correctly read different NP probes
  • Add Neuropixels Opto in the npx_probe dictionary (NP1300)
  • Add new test file and test for NP2 4 shank (from @JoeZiminski)

@alejoe91 alejoe91 added the bug Something isn't working label Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c5e74d9) 89.24% compared to head (2dcb7a5) 88.90%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   89.24%   88.90%   -0.35%     
==========================================
  Files          10       10              
  Lines        1702     1694       -8     
==========================================
- Hits         1519     1506      -13     
- Misses        183      188       +5     
Files Coverage Δ
src/probeinterface/probe.py 92.87% <100.00%> (ø)
src/probeinterface/io.py 87.16% <91.66%> (-0.85%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alejoe91 alejoe91 changed the title Explicitly add NP-Opto and new NP2 OE test Unify NP reading with probe part number (probe_part_number in OE, imDatPrb_pn in SpikeGLX) Nov 2, 2023
@alejoe91 alejoe91 changed the title Unify NP reading with probe part number (probe_part_number in OE, imDatPrb_pn in SpikeGLX) Unify NP reading with probe part number Nov 2, 2023
@samuelgarcia samuelgarcia merged commit aac4339 into main Nov 2, 2023
1 check passed
@alejoe91 alejoe91 deleted the np-opto-ptype branch December 11, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants