-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify NP reading with probe part number #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
alejoe91
commented
Nov 2, 2023
samuelgarcia
reviewed
Nov 2, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 89.24% 88.90% -0.35%
==========================================
Files 10 10
Lines 1702 1694 -8
==========================================
- Hits 1519 1506 -13
- Misses 183 188 +5
☔ View full report in Codecov by Sentry. |
alejoe91
changed the title
Explicitly add NP-Opto and new NP2 OE test
Unify NP reading with probe part number (Nov 2, 2023
probe_part_number
in OE, imDatPrb_pn
in SpikeGLX)
alejoe91
changed the title
Unify NP reading with probe part number (
Unify NP reading with probe part number
Nov 2, 2023
probe_part_number
in OE, imDatPrb_pn
in SpikeGLX)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probe_part_number
in OE andimDatPrb_pn
in SpikeGLX to correctly read different NP probesNeuropixels Opto
in thenpx_probe
dictionary (NP1300)