Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend available NP2 probe types #217

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Extend available NP2 probe types #217

merged 7 commits into from
Oct 27, 2023

Conversation

alejoe91
Copy link
Member

@alejoe91 alejoe91 commented Sep 7, 2023

Added commersial versions of NP2 probes:

  • 2003: single shank - no metal cap
  • 2004: single shank - metal cap
  • 2013: 4 shanks - no metal cap
  • 2014: 4 shanks - metal cap

TODO

  • Add test files and extend tests

@alejoe91 alejoe91 added the enhancement New feature or request label Sep 7, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e5de6f) 88.59% compared to head (543ecdd) 89.07%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   88.59%   89.07%   +0.47%     
==========================================
  Files          10       10              
  Lines        1710     1711       +1     
==========================================
+ Hits         1515     1524       +9     
+ Misses        195      187       -8     
Files Coverage Δ
src/probeinterface/io.py 88.00% <100.00%> (+1.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alejoe91 alejoe91 merged commit 45a6782 into main Oct 27, 2023
1 check passed
@alejoe91 alejoe91 deleted the commercial-np2 branch October 27, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants