Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Biocam brw v4.x files #216

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Add support for Biocam brw v4.x files #216

merged 4 commits into from
Jan 11, 2024

Conversation

mahlzahn
Copy link
Contributor

@mahlzahn mahlzahn commented Sep 7, 2023

  • Missing: test file for brw v4.x file format

See also NeuralEnsemble/python-neo/issues/1324 and corresponding NeuralEnsemble/python-neo/pull/1326

@alejoe91
Copy link
Member

Thanks @mahlzahn

Could you enable the option "Allow edits by maintainers", so that the code is automatically re-formatted?

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (949da47) 88.32% compared to head (368d3f6) 88.41%.
Report is 98 commits behind head on main.

Files Patch % Lines
src/probeinterface/io.py 61.53% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   88.32%   88.41%   +0.09%     
==========================================
  Files          10       10              
  Lines        1644     1718      +74     
==========================================
+ Hits         1452     1519      +67     
- Misses        192      199       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahlzahn
Copy link
Contributor Author

Thanks @mahlzahn

Could you enable the option "Allow edits by maintainers", so that the code is automatically re-formatted?

I already did this, but only after submission. Once I have the test file and tests implemented, I guess the automatic re-formatting should run on the new commit.

@alejoe91
Copy link
Member

Sounds good! Thanks!

@mahlzahn
Copy link
Contributor Author

mahlzahn commented Nov 2, 2023

@alejoe91 I don’t know if you prefer that the new test file is added also here. What do you think?

@alejoe91
Copy link
Member

alejoe91 commented Nov 3, 2023

@mahlzahn since the data is small, I think it's ok to add it here. @samuelgarcia ?

src/probeinterface/io.py Outdated Show resolved Hide resolved
Copy link
Member

@alejoe91 alejoe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahlzahn sorry for the enormous delay.

I have a couple of small suggestions and comments!

src/probeinterface/io.py Outdated Show resolved Hide resolved
src/probeinterface/io.py Outdated Show resolved Hide resolved
src/probeinterface/io.py Outdated Show resolved Hide resolved
@alejoe91 alejoe91 marked this pull request as ready for review January 10, 2024 11:42
@alejoe91
Copy link
Member

@mahlzahn I implemented the couple of changes I suggested. It's ok to merge on my side!

@mahlzahn
Copy link
Contributor Author

Thanks, @alejoe91!

@mahlzahn I implemented the couple of changes I suggested. It's ok to merge on my side!

@alejoe91 alejoe91 merged commit 2cdf024 into SpikeInterface:main Jan 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants