-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Biocam brw v4.x files #216
Conversation
Thanks @mahlzahn Could you enable the option "Allow edits by maintainers", so that the code is automatically re-formatted? |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 88.32% 88.41% +0.09%
==========================================
Files 10 10
Lines 1644 1718 +74
==========================================
+ Hits 1452 1519 +67
- Misses 192 199 +7 ☔ View full report in Codecov by Sentry. |
I already did this, but only after submission. Once I have the test file and tests implemented, I guess the automatic re-formatting should run on the new commit. |
Sounds good! Thanks! |
@mahlzahn since the data is small, I think it's ok to add it here. @samuelgarcia ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahlzahn sorry for the enormous delay.
I have a couple of small suggestions and comments!
@mahlzahn I implemented the couple of changes I suggested. It's ok to merge on my side! |
See also NeuralEnsemble/python-neo/issues/1324 and corresponding NeuralEnsemble/python-neo/pull/1326