Auto downloader + Force patch #3

Maximvdw · 2014-09-09T11:02:09Z

java -jar SpigotPatcher.jar %SPIGOT1649BUILD% download spigot.jar
Will download the latest update

specifying a path still works

java -jar %INPUT% %INPUT.bps% %OUTPUT% force
will overwrite the OUTPUT

java -jar SpigotPatcher.jar <SPIGOT1649BUILD> download spigot.jar Will download the latest update specifying a path still works java -jar <INPUT> <INPUT.bps> <OUTPUT> force will overwrite the OUTPUT

Maximvdw · 2014-09-09T12:50:40Z

src/main/java/org/spigotmc/patcher/Main.java

+				+ Files.hash(outputFile, Hashing.md5()));
+	}
+
+	public static File downloadPatch() {


Main downloader for the patch.
Returns file of downloaded patch (could be used in GUI if threaded)

FarisR99 · 2014-09-09T14:47:53Z

Not sure if it is just my iPad but your code's formatting is horrible here. That's my contribution. 👍

Lemmmy · 2014-09-09T15:47:05Z

+KingFaris10

Maximvdw · 2014-09-09T18:59:05Z

I blame apple

Lemmmy · 2014-09-09T20:21:57Z

I don't blame Apple. I've looked on it on a Windows machine, two Linuxes and an Android and the formatting is terrible. I've also opened the file in a code editor and I can confirm that you have incorrect formatting.

Maximvdw · 2014-09-09T20:36:46Z

Well the formatting is irrelevant (it looks good for me tho)

Lemmmy · 2014-09-09T20:37:18Z

What kind of conventions do you use?

On Tue, Sep 9, 2014 at 9:36 PM, Maxim Van de Wynckel <
[email protected]> wrote:

Well the formatting is irrelevant (it looks good for me tho)

—
Reply to this email directly or view it on GitHub
#3 (comment).

FarisR99 · 2014-09-09T21:11:11Z

^ What LemonLake said...
It's like - one code section per line... argh. I mean - even md_5's formatting isn't good - but I can handle his because a lot of people who either:

Are new to programming. (which is definitely not what md_5 is)
Moved from C or C++ to Java. (Don't think this applies to md_5)
Are rebels and don't want to follow Oracle's Java programming conventions. (This is what md_5 is 👍)
Usually program like he does. Though yours, I can't handle seeing it. Use something like IntelliJ and then use the default format (though still ugly - I have mine modified) to format your code. Unlike Eclipse, IntelliJ unfortunately doesn't auto-format new lines, so you'll have to delete the new line bit and then format and it'll automatically fix the rest. (I'm not sure if there's a setting in IntelliJ to format new lines)

Some people don't like Eclipse's formatting

Maximvdw · 2014-09-09T21:44:14Z

Blame eclipse then, can't believe I woke up to fix this ....
http://i.gyazo.com/7e04924a034387ee30b4590f336f1989.png

It looks good in eclipse, for some reason the eGit ruins the formatting on pushing.

Lemmmy · 2014-09-09T21:58:50Z

Oh god the pain
On 9 Sep 2014 22:44, "Maxim Van de Wynckel" [email protected]
wrote:

Blame eclipse then, can't believe I woke up to fix this ....
http://i.gyazo.com/7e04924a034387ee30b4590f336f1989.png

—
Reply to this email directly or view it on GitHub
#3 (comment).

FarisR99 · 2014-09-10T15:44:17Z

I think the formatting's changed, not sure. But it looks a bit better I think, but there's still the fact that you have so many new lines, e.g.
System
.out
.println()

Just use System.out.println() on one line. Same as strings.

Maximvdw · 2014-09-10T18:34:34Z

We aren't here to discuss formatting.............. its a pull request for an updater

FarisR99 · 2014-09-10T19:11:38Z

It's a pull request for an updater with code made by you which will (if accepted) be published officially with SpigotPatcher's repository. I'm sorry, but we don't want to see ugly code in SpigotPatcher. Formatting is part of a PR. Bukkit rejected PRs that didn't follow a certain formatting.

prayerie · 2014-09-14T19:42:41Z

src/main/java/org/spigotmc/patcher/Main.java

+            System.out
+            .println("\tPlease download it manually from: http://spigotmc.org/spigot-updates/");
+        }
+        return null;
    }
 }


No } Needed, Ending with 2x } (1 for the method downloadPatch) and 1 for the class

Auto downloader + Force patch

76ea2b0

java -jar SpigotPatcher.jar <SPIGOT1649BUILD> download spigot.jar Will download the latest update specifying a path still works java -jar <INPUT> <INPUT.bps> <OUTPUT> force will overwrite the OUTPUT

Maximvdw reviewed Sep 9, 2014
View reviewed changes

Formatting

e938a9f

Some people don't like Eclipse's formatting

prayerie reviewed Sep 14, 2014
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto downloader + Force patch #3

Auto downloader + Force patch #3

Maximvdw commented Sep 9, 2014

Maximvdw Sep 9, 2014

FarisR99 commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

Maximvdw commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

Maximvdw commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

FarisR99 commented Sep 9, 2014

Maximvdw commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

FarisR99 commented Sep 10, 2014

Maximvdw commented Sep 10, 2014

FarisR99 commented Sep 10, 2014

prayerie Sep 14, 2014

Maximvdw Sep 14, 2014

Auto downloader + Force patch #3

Are you sure you want to change the base?

Auto downloader + Force patch #3

Conversation

Maximvdw commented Sep 9, 2014

Maximvdw Sep 9, 2014

Choose a reason for hiding this comment

FarisR99 commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

Maximvdw commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

Maximvdw commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

FarisR99 commented Sep 9, 2014

Maximvdw commented Sep 9, 2014

Lemmmy commented Sep 9, 2014

FarisR99 commented Sep 10, 2014

Maximvdw commented Sep 10, 2014

FarisR99 commented Sep 10, 2014

prayerie Sep 14, 2014

Choose a reason for hiding this comment

Maximvdw Sep 14, 2014

Choose a reason for hiding this comment