Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VDX-332 digidentity implementation #1

Open
wants to merge 7 commits into
base: pkcs7
Choose a base branch
from
Open

VDX-332 digidentity implementation #1

wants to merge 7 commits into from

Conversation

sanderPostma
Copy link
Contributor

No description provided.

@sanderPostma sanderPostma requested a review from zoemaas March 19, 2024 21:02
zoemaas
zoemaas reviewed Mar 20, 2024
View reviewed changes
Copy link

@zoemaas zoemaas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want someone else to approve it due my lack of experience with this project. By the way, the build is failing

@nklomp
Copy link
Contributor

nklomp commented Mar 20, 2024

For sure should not be merged before I have reviewed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoemaas zoemaas zoemaas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanderPostma @nklomp @zoemaas