-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/SDK-8 #27
Merged
Merged
feature/SDK-8 #27
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
81fff51
feat: Added secp256r1 key to createIdentifier() method
zoemaas 89968e5
chore: Associated the keys with the verification relationship
zoemaas b988892
refactor: Add trailing new line to types.ts
zoemaas e2b485b
refactor: Prettier
zoemaas d97e1eb
chore: Added default verification relationships
zoemaas 0b44f54
chore: Added tests and run prettier
zoemaas 29e4f59
refactor: Simplified structures, extracted more methods and run prettier
zoemaas 99e8f39
Merge branch 'develop' of github.com:Sphereon-Opensource/SSI-SDK-cryp…
zoemaas b0ac3b5
feat: Implemented conversion of public keys, rpc service and document…
zoemaas 36dc9b7
chore: Implemented the getDidDocument and listDids methods
zoemaas 3c1ef0d
feat: Implemented integration of the ebsi rpc service with the ebsi d…
zoemaas 1d2e04d
fix: Bugfix creating eth transactions
zoemaas 35f1f6b
refactor: Added missing notBefore and notAfter properties to options
zoemaas 32f3572
Merge branch 'develop' of github.com:Sphereon-Opensource/SSI-SDK-cryp…
zoemaas c91fdf2
refactor: Fixed merging issues
zoemaas 34b8d43
refactor: Made token an argument of rpc functions
zoemaas 5d672b2
refactor: Refactored the formatEbsiPublicKey function
zoemaas 12c1a14
refactor: Refactored how the RPC url is built
zoemaas 9ccacbf
refactor: Extracted a method from to build/populate fetch options
zoemaas 74a1589
refactor: Extracted nested string interpolation into ternary
zoemaas 317ac2d
refactor: Extracted multiple if clauses to build the query string
zoemaas 137504f
refactor: Added query url to getUrls method
zoemaas 725dc37
refactor: Run prettier
zoemaas 773726f
refactor: Removed the jose dependency
zoemaas 7b141f8
refactor: updated pnpm-lock.yaml
zoemaas dace576
refactor: Added comment about the conversion of JWK in hex string.
zoemaas 615eb48
refactor: Renamed function
zoemaas a81ebfe
refactor: extracted interface from params of method createEbsiDid
zoemaas f2efdcd
refactor: extracted interface from params of method updateIdentifier
zoemaas 9b2b5b7
refactor: extracted constant baseDocument
zoemaas b2d685e
refactor: removed the implementation of updateIdentifier method and t…
zoemaas bb5e60f
refactor: added new keyword to Errors that might be thrown
zoemaas 38a486f
refactor: moved Veramo unrelated methods to functions.ts
zoemaas 60602c4
refactor: Renamed checkPresent function to assertPresent
zoemaas 1c7680b
refactor: Refactored the EBSI RPC methods
zoemaas dbb51ef
refactor: Removed unused dependency
zoemaas 07d320a
fix: Fixed broken tests
zoemaas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean with not inferable? Of course I know what the did is. Also this is an optional method to implement once you want to work with passing in updated (partial) did documents. The regular way would be the add/remove service endpoint and add/remove keys methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will actually change in the did? That's the request body:
And there is no did document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thenit is likely this method should not have been implemented to begin with and throw an error instead. Veramo uses add and delete services and keys methods to manage updates to the identifier and did document. It recently added a method to pass in a new (partial) did document. If however a did provider cannot work with that it should throw an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just throwing an error then