Skip to content

Commit

Permalink
Merge pull request #57 from Sphereon-Opensource/feature/SPRIND-124_esim
Browse files Browse the repository at this point in the history
chore: eSim workarounds
  • Loading branch information
sanderPostma authored Dec 5, 2024
2 parents 650ee51 + d6abe65 commit ae9e285
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 14 deletions.
2 changes: 1 addition & 1 deletion packages/kms-musap-rn/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"build:clean": "tsc --build --clean && tsc --build"
},
"dependencies": {
"@sphereon/musap-react-native": "0.2.1-unstable.161",
"@sphereon/musap-react-native": "0.2.1-next.164",
"@sphereon/ssi-sdk-ext.key-utils": "workspace:*",
"@sphereon/ssi-sdk-ext.x509-utils": "workspace:*",
"@sphereon/ssi-types": "0.30.2-feature.SDK.41.oidf.support.286",
Expand Down
8 changes: 6 additions & 2 deletions packages/kms-musap-rn/src/MusapKeyManagerSystem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,12 @@ export class MusapKeyManagementSystem extends AbstractKeyManagementSystem {
}

async deleteKey({ kid }: { kid: string }): Promise<boolean> {
try {
void this.musapClient.removeKey(kid)
try {
const key: MusapKey = this.musapClient.getKeyById(kid) as MusapKey
if (key.sscdType as string === 'External Signature') {
return true // FIXME we can't remove a eSim key for now because this would mean onboarding again
}
void this.musapClient.removeKey(kid)
return true
} catch (error) {
console.warn('Failed to delete key:', error)
Expand Down
22 changes: 11 additions & 11 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ae9e285

Please sign in to comment.