This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Updating to OID4VP_1_0_20 #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklomp
reviewed
Apr 28, 2024
| // outputConstName: 'AuthorizationRequestPayloadSchemaVD11', | ||
| skipTypeCheck: true | ||
| }; | ||
|
|
||
| let schemas: Schema[] = [ | ||
| writeSchema(authorizationRequestPayloadVID1), | ||
| writeSchema(authorizationRequestPayloadVD11), | ||
| writeSchema(authorizationRequestPayloadVD12OID4VPD18), |
nklomp
reviewed
Apr 28, 2024
| @@ -1,4 +1,7 @@ | |||
| import { JWTVerifyOptions } from 'did-jwt'; | |||
| import { decodeJWT } from 'did-jwt'; | |||
| import { JWTDecoded } from 'did-jwt/lib/JWT'; | |||
| import forge from 'node-forge'; | |||
There was a problem hiding this comment.
This cannot work. This library is used in browser, RN and Node. The lib is node only
nklomp
reviewed
Apr 28, 2024
| @@ -34,15 +34,15 @@ export const authorizationRequestVersionDiscovery = (authorizationRequest: Autho | |||
| const versions = []; | |||
| const authorizationRequestCopy: AuthorizationRequestPayload = JSON.parse(JSON.stringify(authorizationRequest)); | |||
| // todo: We could use v11 validation for v12 for now, as we do not differentiate in the schema at this point\ | |||
| const vd12Validation = AuthorizationRequestPayloadVD12OID4VPD18Schema(authorizationRequestCopy); | |||
There was a problem hiding this comment.
Don't remove older versions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated in this pr:
implemented the checks for verifier_attestation and san_dns