Data ag kuppe #109
Open
Data ag kuppe #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also #32 |
niklasmueboe
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Please remove this file
|
|
||
|
|
||
| BAD_GENES = ["eGFP","mCherry2","tdToma"] | ||
| META_DICT = {"technology":"Merfish"} |
There was a problem hiding this comment.
Given that this does not download a public dataset but rather curates data that already needs to be present I am not sure if it makes sense to ad the script to the repo?
Don't get me wrong we can definitely still use the data!
@naveedishaque what is our take on this
There was a problem hiding this comment.
Not sure. I would say we keep it as it is required to take the data from the current source. IF the sources changes, then we don't need the script, but right now we do. Maybe tag the dataset as a "v1"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code setups our heart and kidney dataset.
This is preliminary as our datasets are currently behind credentials in our bucket, need to transfer them to git LFS or similiar at some point.
Code should in principle work with any Vizgen Merscope output