Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Riobaian create navbar #20

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Riobaian create navbar #20

wants to merge 6 commits into from

Conversation

Rioba-Ian
Copy link

Description

Implements the Navbar component with styling for responsiveness for both mobile and desktop. I have also removed the default css App.css which was used to style the boiler plate content from Vite+React. In doing so, I added css defaults in index.css which can be applied to the app.

Fixes #6

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using chrome dev tools to change from various screen sizes of large desktops : 1920 to small screen sizes : 260px. I've added css breakpoints in Navbar.css to handle responsiveness on where the layout tends to break

  • Chrome Dev tools

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

nyandika
nyandika previously approved these changes Apr 28, 2023
Copy link
Collaborator

@nyandika nyandika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the test case for the login and sign up buttons to fix the failing tests
Otherwise looks good

Copy link
Collaborator

@nyandika nyandika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Rioba-Ian Rioba-Ian requested a review from hellen-22 May 2, 2023 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Navbar Component
2 participants