Tokio tungstenite #184
Open
Tokio tungstenite #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue with get members where get members would only return one of the server members. Fix: Added Query Paremeters as optionals for the API call. Optional values defaults per [Discords Documentation](https://discord.com/developers/docs/resources/guild#list-guild-members)
Upgraded to Rust edition 2021 in preparation to migrate to tungstinite.
Added an async version of both the `SenderExt` and `ReceieverExt` Traits. This should allow us to have the connection contain the tokio runtime.
I don't know that this was actually going to be that helpful, and I think this might have been the wrong place for it regardless.
Added type aliases back but made them private.
`url` for parsing the url to send to tungstenite. `rand` for generatting the jitter. `simplelog` in dev dependencies to get logs when running examples
keepalive_V2 is an async version of the keepalive function meant to be run on a tokio task / thread.
To give more seperation between async and sync code an async connection struct has been built. The connection struct will be modified to wrap the async connection along with a tokio runtime.
Added presence functions to the async client
Connection is now a wrapper around the AsyncConnection bundling the async connection with the tokio runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR, wanted to get your thoughts on the approach before I sunk any more time into this.