Cap, Touch Bar, & Control Updates #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycate
requested changes
Mar 14, 2022
electron/packetDefs.js
Outdated
Comment on lines
260
to
268
| 221: [ | ||
| ['capVal', asFloat], | ||
| ['capValFiltered', asFloat], | ||
| ['capTemperature', asFloat], | ||
| ], | ||
| 222: [ | ||
| ['capVal', asFloat], | ||
| ['capValFiltered', asFloat], | ||
| ['capTemperature', asFloat], |
There was a problem hiding this comment.
Why are there two different packets here?
There was a problem hiding this comment.
Not sure, @xy3710’s doing
telemetry/src/Control.js
Outdated
Comment on lines
547
to
564
| <Grid item={1} xs={3} className={classes.item}> | ||
| <Grid container spacing={1} direction='column'> | ||
| <Grid item> | ||
| <ButtonGroup | ||
| open={comms.activateLoxTankMidHtr} | ||
| close={comms.deactivateLoxTankMidHtr} | ||
| text='Main Valve Vent' | ||
| /> | ||
| </Grid> | ||
| <Grid item> | ||
| <ButtonGroup | ||
| open={comms.activateLoxTankBottomHtr} | ||
| close={comms.deactivateLoxTankBottomHtr} | ||
| text='RQD' | ||
| /> | ||
| </Grid> | ||
| </Grid> | ||
| </Grid> |
There was a problem hiding this comment.
Yea, aware of that - making a quick n dirty fix while at RFS. Wanted to still get what we used merged into main, and will make a new branch with updated backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cap changes:
TouchBar
Control
**still need to update backend naming conventions/telemetry for Main Valve Vent & RQD, currently just on LOX tank heater channels