-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial testing foundation #33
Conversation
9036c8b
to
b417dc3
Compare
Additional note: I do not agree with all formatting rules applied. The still marked "formatting error" for the ternary operator does not make sense at all and mixes condition with return value for one but not both possibilities. |
I don't really know, which rule was applied on that line, but I think, probably the line was to long with the else statement in the first line, so it did the line break before else? In my opinion, the else in the second line is better to read, because now it is more visible, that the AUTH_FAILED is part of the ternary the line before |
Please also use type hints for method arguments and return values |
6164de7
to
3cb57f4
Compare
3d41d87
to
b441597
Compare
def14ca
to
481882d
Compare
Signed-off-by: Tobias Wolf <[email protected]>
481882d
to
7c946d5
Compare
This PR adds the initial testing foundation:
Closes #14