Ensure we are validating current Ceph status data for migration #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes introduced in #86 and updated in #93 only partly considered when data is taken from `analyze_ceph` and when to query Ceph for current status data. This resulted in always assuming RGW daemons got successfully migrated immediately. Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
added a commit
that referenced
this pull request
Nov 10, 2024
Signed-off-by: Tobias Wolf <[email protected]>
boekhorstb1
approved these changes
Nov 11, 2024
NotTheEvilOne
deleted the
fix/false-positive-daemon-status-in-migrate-rgws-module
branch
NotTheEvilOne
added a commit
that referenced
this pull request
Nov 13, 2024
* Be more permissive for Ceph RGW services to be empty in `migrate_rgws` * Ensure we are validating current Ceph status data for migration * Adapt to changes of PR #101 Fixes: #98 Signed-off-by: Tobias Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced in #86 and updated in #93 only partly considered when data is taken from
analyze_cephand when to query Ceph for current status data. This resulted in always assuming RGW daemons got successfully migrated immediately.Related: #98