Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError issues introduced in #86 #100

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

NotTheEvilOne
Copy link
Contributor

This PR fixes an issue updated in #86 if no RGW services are in the Ceph servicemap.

Fixes: #98

@NotTheEvilOne NotTheEvilOne added bug Something isn't working module Rookify module labels Nov 5, 2024
@NotTheEvilOne NotTheEvilOne self-assigned this Nov 5, 2024
Copy link

@b1-lender b1-lender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NotTheEvilOne NotTheEvilOne merged commit 49641ad into main Nov 6, 2024
4 checks passed
@NotTheEvilOne NotTheEvilOne deleted the fixes/fix-86-introduced-key-issues branch November 6, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module Rookify module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate_rgws may fail with KeyError
2 participants