Skip to content

Commit

Permalink
Ensure we are validating current Ceph status data for migration
Browse files Browse the repository at this point in the history
Changes introduced in #86 and updated in #93 only partly considered when data is taken from `analyze_ceph` and when to query Ceph for current status data. This resulted in always assuming RGW daemons got successfully migrated immediately.

Signed-off-by: Tobias Wolf <[email protected]>
  • Loading branch information
NotTheEvilOne committed Nov 7, 2024
1 parent 49641ad commit bcdf825
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/rookify/modules/migrate_rgws/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,11 @@ def _migrate_rgw(self, rgw_host: str) -> None:
)

while True:
rgw_daemon_hosts = self._get_rgw_daemon_hosts()
ceph_status = self.ceph.mon_command("status")

rgw_daemon_hosts = self._get_rgw_daemon_hosts_of_map(
ceph_status["servicemap"]["services"]["rgw"]["daemons"]
)

if rgw_host in rgw_daemon_hosts:
break
Expand Down

0 comments on commit bcdf825

Please sign in to comment.