-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OVN LB support #687
OVN LB support #687
Conversation
Signed-off-by: Roman Hros <[email protected]>
Signed-off-by: Roman Hros <[email protected]>
Build canceled (e2e-quick-test pipeline). |
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 25m 59s Warning: Sonobouy results=== Collecting results === time="2024-02-05T15:15:23Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2024-02-05T15:15:23Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-02-05T15:15:23Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7213 Passed: 5 Failed: 0 Skipped: 7208Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-02-05 15:15:30 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Custom ENV config
|
Build failed (e2e-test pipeline). ❌ k8s-cluster-api-provider-e2e-conformance FAILURE in 25m 15s Warning: Custom ENV config
|
Build succeeded (e2e-test pipeline). ✔️ k8s-cluster-api-provider-e2e-conformance SUCCESS in 2h 15m 31s Warning: Sonobouy results=== Collecting results === time="2024-02-06T07:55:45Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2024-02-06T07:55:45Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-02-06T07:55:45Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-02-06T07:55:45Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=pods-3978 Plugin: e2e Status: passed Total: 7213 Passed: 382 Failed: 0 Skipped: 6831Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-02-06 07:55:51 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [pods-3978] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. All E2E namespaces deleted Custom ENV config
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
- end-to-end tests prove that this works
- now we could consider OVN LB as a default (but this could be addressed in a separate PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@garloff, can you please close kubernetes/cloud-provider-openstack#2234? |
Done. |
All the upstream issues (kubernetes/cloud-provider-openstack#2225, kubernetes/cloud-provider-openstack#2489, osism/issues#499) were resolved, we do not need
--allow-preview-features
for the OVN load balancer in front of ingress nginx.Related to #407
Fixes #672
Fixes SovereignCloudStack/issues#298
close kubernetes/cloud-provider-openstack#2234 also after this is merged