Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip OPS call tomorrow since most of us are at IAM Hackathon in HB #147

Merged
merged 2 commits into from
Apr 13, 2023
Merged

skip OPS call tomorrow since most of us are at IAM Hackathon in HB #147

merged 2 commits into from
Apr 13, 2023

Conversation

fkr
Copy link
Member

@fkr fkr commented Apr 12, 2023

No description provided.

@fkr fkr requested a review from garloff April 12, 2023 13:56
@fkr
whoops. a tab char.
b07feea 
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
garloff
garloff approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@garloff garloff merged commit abc8d54 into main Apr 13, 2023
@garloff garloff deleted the feat/skip-ops-call-cw15 branch April 13, 2023 04:39
@garloff
Copy link
Member

garloff commented Apr 13, 2023

I should note that I used the also_on functionality which was contributed by @itrich and merged upstream, but is not yet present in a released version of yaml2ics, unfortunately. Goal is to get a released/tagged version soon (scientific-python/yaml2ics#49), otherwise we may need to change the build process to use the git main branch version of yaml2ics (which is non-trivial) for building the calendar or maybe just implement the also_on manually for now ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garloff garloff garloff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkr @garloff