Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken fuzz lib #984

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix: broken fuzz lib #984

merged 3 commits into from
Oct 5, 2023

Conversation

vlopes11
Copy link
Contributor

@vlopes11 vlopes11 commented Oct 4, 2023

Prior to this commit, there was no CI check for the fuzz library.

Since it is isolated from the workspace (so it won't be affected by fuzz specific build configuration), it could be silently broken by a breaking change.

This commit introduces a fix to AccountConfig, and adds the fuzz check to the link job of the Makefile.

Prior to this commit, there was no CI check for the fuzz library.

Since it is isolated from the workspace (so it won't be affected by fuzz
specific build configuration), it could be silently broken by a breaking
change.

This commit introduces a fix to `AccountConfig`, and adds the fuzz check
to the link job of the `Makefile`.
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since fuzz is in a separate workspace, we need to change the caching configuration, otherwise it will compile from scratch for every CI run (our caching configuration is workspace-based). I'll propose a change below:

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Filippo Costa <[email protected]>
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to a separate branch as a suggestion on how to fix the CI caching:

aadfefe

@vlopes11
Copy link
Contributor Author

vlopes11 commented Oct 5, 2023

@neysofu amazing suggestion, pushed it into the branch!

@vlopes11 vlopes11 enabled auto-merge October 5, 2023 12:20
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #984 (74a1954) into nightly (66c27de) will decrease coverage by 0.1%.
The diff coverage is n/a.

see 2 files with indirect coverage changes

@vlopes11 vlopes11 requested a review from neysofu October 5, 2023 18:55
@vlopes11 vlopes11 added this pull request to the merge queue Oct 5, 2023
@vlopes11 vlopes11 disabled auto-merge October 5, 2023 18:57
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 5, 2023
@vlopes11 vlopes11 added this pull request to the merge queue Oct 5, 2023
Merged via the queue into nightly with commit 1a73dae Oct 5, 2023
11 checks passed
@vlopes11 vlopes11 deleted the vlopes11/fix/broken-fuzz branch October 5, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants