-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken fuzz lib #984
fix: broken fuzz lib #984
Conversation
Prior to this commit, there was no CI check for the fuzz library. Since it is isolated from the workspace (so it won't be affected by fuzz specific build configuration), it could be silently broken by a breaking change. This commit introduces a fix to `AccountConfig`, and adds the fuzz check to the link job of the `Makefile`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since fuzz
is in a separate workspace, we need to change the caching configuration, otherwise it will compile from scratch for every CI run (our caching configuration is workspace-based). I'll propose a change below:
Signed-off-by: Filippo Costa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to a separate branch as a suggestion on how to fix the CI caching:
@neysofu amazing suggestion, pushed it into the branch! |
Prior to this commit, there was no CI check for the fuzz library.
Since it is isolated from the workspace (so it won't be affected by fuzz specific build configuration), it could be silently broken by a breaking change.
This commit introduces a fix to
AccountConfig
, and adds the fuzz check to the link job of theMakefile
.