Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream avail adapter #905

Merged
merged 15 commits into from
Oct 4, 2023
Merged

Upstream avail adapter #905

merged 15 commits into from
Oct 4, 2023

Conversation

preston-evans98
Copy link
Member

Description

This PR merges the avail adapter as implemented by @vibhurajeev. Demos and end-to-end tests using the adapter will be PR'd separately.

@preston-evans98 preston-evans98 changed the title Preston/avail Upstream avail adapter Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #905 (035035c) into nightly (7a05e1f) will decrease coverage by 1.5%.
The diff coverage is 0.0%.

Files Coverage Δ
adapters/avail/src/spec/mod.rs 0.0% <0.0%> (ø)
adapters/avail/src/avail.rs 0.0% <0.0%> (ø)
adapters/avail/src/spec/hash.rs 0.0% <0.0%> (ø)
adapters/avail/src/spec/address.rs 0.0% <0.0%> (ø)
adapters/avail/src/spec/block.rs 0.0% <0.0%> (ø)
adapters/avail/src/spec/header.rs 0.0% <0.0%> (ø)
adapters/avail/src/verifier.rs 0.0% <0.0%> (ø)
adapters/avail/src/spec/transaction.rs 0.0% <0.0%> (ø)
adapters/avail/src/service.rs 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

@citizen-stig
Copy link
Member

@preston-evans98 is it possible to add at least some tests? For example for types conversion?

Ideally we would like to have tests with wiremock, including error cases and timeouts.

@preston-evans98 preston-evans98 added this pull request to the merge queue Oct 4, 2023
Merged via the queue into nightly with commit 9f17962 Oct 4, 2023
@preston-evans98 preston-evans98 deleted the preston/avail branch October 4, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants