-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a versioned KernelStateValue
which is only partially accessible from user space
#1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e8326d.
preston-evans98
force-pushed
the
preston/kernel-state
branch
from
November 17, 2023 23:21
0efd829
to
029cf03
Compare
cemozerr
reviewed
Nov 20, 2023
cemozerr
reviewed
Nov 20, 2023
cemozerr
reviewed
Nov 20, 2023
cemozerr
reviewed
Nov 20, 2023
bkolad
reviewed
Nov 20, 2023
bkolad
reviewed
Nov 20, 2023
bkolad
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes two related changes:
slot_height
method toContext
. This simple change accounts for almost all of the lines changedKernelStateValue
type which appears as amap
fromslot_number
tovalue
when accessed from thekernel
, but appears as a regular state value (which may be absent) when accessed from user space. To support this value, two new variants ofWorkingSet
are introduced - aKernelWorkingSet
which can only be constructed by aKernel
, and aVersionedWorkingSet
, which is constructed from the context and allows access to only the current version of aKernel
Value.Testing
Tests have been added to cover the new
KernelStateValue
's behavior