-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mock adapters to separate crates #1128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
citizen-stig
changed the title
Move mock adapters to separate create
Move mock adapters to separate crates
Nov 1, 2023
bkolad
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please also update sov-seq-starter
with the relevant changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mocks
feature insov-rollup-interface
sov-mock-da
andsov-mock-zkvm
verifier
feature from all DA adaptersdemo-simple-stf
was calling "native" method fromBlobReader
. There is some work needs to be done:demo-simple-stf
uses native code insideapply_slot
. #1129(!) Note.
sov-mock-da
should be imported with "native" flag if any module is imported with native flag, because modules indirectly importrollup-interface
with native, which means thatsov-mock-da
can have not fully implementBlobReader
if it also does not have "native"Testing
Existing tests are passing
Docs
Documentation has been updated