Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tokio as part of native feature #1117

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

vlopes11
Copy link
Contributor

Prior to this commit, tokio was split from the rollup-interface native feature so the ledger functionality would be available for no-std.

This commit simplifies the structure and will require std/tokio when native is active.

Prior to this commit, `tokio` was split from the `rollup-interface`
native feature so the ledger functionality would be available for
no-std.

This commit simplifies the structure and will require `std/tokio` when
`native` is active.
Copy link
Member

@preston-evans98 preston-evans98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1117 (fe4518d) into nightly (b0348ee) will decrease coverage by 0.1%.
The diff coverage is n/a.

Files Coverage Δ
rollup-interface/src/node/rpc/mod.rs 89.2% <ø> (ø)

... and 1 file with indirect coverage changes

@vlopes11 vlopes11 enabled auto-merge October 27, 2023 20:55
@vlopes11 vlopes11 added this pull request to the merge queue Oct 27, 2023
Merged via the queue into nightly with commit bd469c7 Oct 27, 2023
15 checks passed
@vlopes11 vlopes11 deleted the vlopes11/feature/rol-interface-native-tokio branch October 27, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants