-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DbSnapshot
to sov-db-schema
#1112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
citizen-stig
changed the title
Add Oct 27, 2023
sov-db-schema
with snapshotsDbSnapshot to
sov-db-schema`
20 tasks
citizen-stig
changed the title
Add
Add Oct 27, 2023
DbSnapshot to
sov-db-schema`DbSnapshot
to sov-db-schema
bkolad
reviewed
Oct 27, 2023
bkolad
reviewed
Oct 27, 2023
bkolad
approved these changes
Oct 27, 2023
neysofu
reviewed
Oct 27, 2023
neysofu
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
DbSnapshot
, a wrapper aroundsov_schema_db::DB
, which has it's local cache in form of adaptedSchemaBatch
and link toQueryManager
. This allowsDbSnapshot
read/write value to local cache, fetch them from parent snapshots or directly from DB.Please note, that this functionality is added, but it is not integrated. Next step would be modifying
StateDB
,NativeDB
andLedgerDB
to work withDbSnapshot
instead ofDB
directly.Main modifications:
sov_schema_db::SchemaBatch
: vector of operations replaced with HashMap, which allows efficient reads.Mutex
is removed fromSchemaBatch
and now it is responsibility of the caller to handle. Current usage of SchemaBatch is not concurrent.DbSnapshot
usesMutex
over whole internal cache. Potentially related to Make writes ofSchemaBatch
es atomic acrossStateDb
'sJmtNodes
,JmtValues
, andNativeDb
's accessory state #791Linked Issues
Testing
New integration test has been added to test snapshot
Docs
Documentation to the new modules have been added