-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract storage creation from State Transition Function #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizen-stig
changed the title
Extract storage persistence from State Transition Function
Extract storage creation from State Transition Function
Oct 25, 2023
citizen-stig
force-pushed
the
nikolai/extract_persistence_from_stf
branch
from
October 25, 2023 10:49
506001b
to
a96221c
Compare
Codecov Report
|
citizen-stig
commented
Oct 25, 2023
module-system/module-implementations/examples/sov-accessory-state/tests/test.rs
Outdated
Show resolved
Hide resolved
citizen-stig
commented
Oct 25, 2023
citizen-stig
commented
Oct 25, 2023
bkolad
reviewed
Oct 25, 2023
bkolad
reviewed
Oct 25, 2023
bkolad
reviewed
Oct 25, 2023
bkolad
reviewed
Oct 25, 2023
bkolad
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this is merged, can you please update https://github.com/Sovereign-Labs/sov-rollup-starter as well?
bkolad
reviewed
Oct 26, 2023
bkolad
approved these changes
Oct 26, 2023
20 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first step for implementing reorgs support.
This PR includes:
StateTransitionFunction
, by adding extra types that will neededProverStorage
only writes to underlyingdb
in commit, and not incompute_state_update
. Except for empty JMT case. Added todo for this.StorageManager
torollup-interface
which is temporary placeholder before ForkManager arrives:Decision to keep AppTemplate committing to database is made for 2 reasons:
ProverStorage
will be transformed to work over snapshots, then it won't be actual commit to database, but to Snapshot.Storage
can become read-only over underlyingstorage
. This is up to discussion. But it will simplifyStorage
trait a little bit.Minor changes
app
anddemo
tostf
ST
toStf
according to generics naming convention.ProverStorage::db()
method, as it is used only in testsruntime
attribute from AppTemplate to be crate public instead of completely public, as it was only used for tests.Linked Issues
Testing
All existing tests are passing.
Docs
Documentation has been updated