Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More succint GenesisPaths initialization #1012

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Oct 10, 2023

Description

New method GenesisPaths::from_dir which simplifies struct initialization.

Testing

Existing test suite, no new tests.

Signed-off-by: Filippo Costa <[email protected]>
@neysofu neysofu force-pushed the filippo/genesis-config branch from 760acbc to 29000b3 Compare October 10, 2023 11:50
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1012 (760acbc) into nightly (9e65601) will decrease coverage by 0.1%.
Report is 4 commits behind head on nightly.
The diff coverage is n/a.

❗ Current head 760acbc differs from pull request most recent head 8414378. Consider uploading reports for the commit 8414378 to get more accurate results

see 3 files with indirect coverage changes

@neysofu
Copy link
Member Author

neysofu commented Oct 10, 2023

There's a compilation error related to experimental feature gating; will fix asap.

Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
@neysofu neysofu added this pull request to the merge queue Oct 10, 2023
Merged via the queue into nightly with commit a9bb4d8 Oct 10, 2023
12 checks passed
@neysofu neysofu deleted the filippo/genesis-config branch October 10, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants