Tendermint merkle hash #21
Conversation
|
Hey @S1nus! Thanks for the PR! The implementation looks like it faithfully reproduces the tendermint merkle hasher to me - but I'm not quite sure what the motivation is. We're happy to merge this if there's a usecase, but I'm not aware of the feature request yet if so! On the implementation side, the new code doesn’t seem to be linked to the file tree (looks like we’re missing an entry in lib.rs), and it also looks like we're missing a few doc comments on public items. |
|
Hey @preston-evans98 , the motivation is because tendermint-rs seems to lack code for generating leaf / range proofs. I think nmt-rs is the right place for this contribution rather than tendermint-rs, because tendermint-rs merkle code lacks any sort of way to persist the trees. It seems it's meant for verifying commitments, not generating proofs. |
A MerkleHash implementation for the tendermint simple merkle tree, used by Celestia for row / column inclusion proofs into data roots