Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging #23

Merged
merged 9 commits into from
Dec 8, 2020
Merged

Merging #23

merged 9 commits into from
Dec 8, 2020

Conversation

damla
Copy link
Member

@damla damla commented Dec 8, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Merging the changes done in main branch.

Added tests?

  • Yes
  • No, and this is why: Not required.
  • I need help with writing tests

Added to documentation?

  • Docs
  • README
  • No documentation needed

@damla damla requested a review from ilter December 8, 2020 14:24
@damla damla self-assigned this Dec 8, 2020
@damla damla added enhancement New feature or request refactor Improvements or changes in code labels Dec 8, 2020
@damla damla added this to the v1.0.0 milestone Dec 8, 2020
This was linked to issues Dec 8, 2020
Copy link
Contributor

@ilter ilter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@damla damla merged commit 4f627af into dev Dec 8, 2020
damla added a commit that referenced this pull request Dec 8, 2020
Merge pull request #23 from sdtrdev/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Improvements or changes in code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚧 Adding Templates 🚧 🚧 Adding New Titles 🚧
4 participants